form elements inherit line height from ancestor#735
Open
jzilg wants to merge 1 commit intonecolas:masterfrom
jzilg:form-elements-inherit-line-height
Open
form elements inherit line height from ancestor#735jzilg wants to merge 1 commit intonecolas:masterfrom jzilg:form-elements-inherit-line-height
jzilg wants to merge 1 commit intonecolas:masterfrom
jzilg:form-elements-inherit-line-height
Conversation
|
Maybe we can do the same with |
|
|
|
|
I just tested this and found it to be incorrect. There is no difference between |
richgerdes
added a commit
to libgranite/normalize.css
that referenced
this pull request
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is more practical if the form elements inherit the line height instead of set it fix to 1.15. So if you change the line height of your root or any ancestor element, it will apply to your form elements.