Skip to content

form elements inherit line height from ancestor#735

Open
jzilg wants to merge 1 commit intonecolas:masterfrom
jzilg:form-elements-inherit-line-height
Open

form elements inherit line height from ancestor#735
jzilg wants to merge 1 commit intonecolas:masterfrom
jzilg:form-elements-inherit-line-height

Conversation

@jzilg
Copy link
Copy Markdown

@jzilg jzilg commented Mar 27, 2018

I think it is more practical if the form elements inherit the line height instead of set it fix to 1.15. So if you change the line height of your root or any ancestor element, it will apply to your form elements.

@frenzzy
Copy link
Copy Markdown

frenzzy commented Mar 27, 2018

Maybe we can do the same with font-size ?

@safareli
Copy link
Copy Markdown

safareli commented Apr 27, 2018

big 👍 for inheriting font-size and line-height see comment by @stof

@stof
Copy link
Copy Markdown

stof commented Jul 31, 2018

font-size: 100% is precisely what allows to use the same font-size than the parent (inheriting the value might end up using a different computed value if the parent is using a em or percentage for the font-size, as the inherited value is not the computed one, but the percentage itself)

@benface
Copy link
Copy Markdown

benface commented Mar 8, 2019

inheriting the value might end up using a different computed value if the parent is using a em or percentage for the font-size, as the inherited value is not the computed one, but the percentage itself

I just tested this and found it to be incorrect. There is no difference between inherit, 100%, and 1em even if the parent has a font-size in em or %.

richgerdes added a commit to libgranite/normalize.css that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants